Change in vdsm[master]: spec: vdsm pkg for EL distro must include pkla

dougsland at redhat.com dougsland at redhat.com
Wed Feb 5 17:20:00 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: spec: vdsm pkg for EL distro must include pkla
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/24083/1/vdsm.spec.in
File vdsm.spec.in:

Line 659: %endif
Line 660: 
Line 661: # Install the configuration sample
Line 662: install -Dm 0644 lib/vdsm/vdsm.conf.sample \
Line 663:                  %{buildroot}%{_sysconfdir}/%{vdsm_name}/vdsm.conf
> iirc we don't want to ship vdsm.conf.sample on rhel, don't recall the reaso
ok, let's keep the %if !0%{?rhel} as the original or if danken prefer we can remove it.
Line 664: 
Line 665: # Install the polkit for libvirt
Line 666: %if 0%{?fedora} >= 18
Line 667: install -Dm 0644 vdsm/vdsm-libvirt-access.rules \


Line 664: 
Line 665: # Install the polkit for libvirt
Line 666: %if 0%{?fedora} >= 18
Line 667: install -Dm 0644 vdsm/vdsm-libvirt-access.rules \
Line 668:                  %{buildroot}%{_polkitdir}/10-vdsm-libvirt-access.rules
> that's never been called and all was fine. are we sure we really need this 
It has been called for fedora users, all fedora need this.
Line 669: %else
Line 670: install -Dm 0644 vdsm/vdsm-libvirt-access.pkla \
Line 671:                  %{buildroot}%{_polkitdir}/10-vdsm-libvirt-access.pkla
Line 672: %endif


-- 
To view, visit http://gerrit.ovirt.org/24083
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I298f21ee6a3e5f2fdf78939ea421a2152490972b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list