Change in vdsm[master]: fencing: use deathSignal to keep scripts at bay

danken at redhat.com danken at redhat.com
Wed Feb 5 15:57:08 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: fencing: use deathSignal to keep scripts at bay
......................................................................


fencing: use deathSignal to keep scripts at bay

Before this patch, the fenceNode verb used a knowingly-raceful code to
wait for pending fencing scripts, and kill them when Vdsm exited.
This patch makes sure that deathSignal is sent to pending scripts if
Vdsm exits or crashes.

We require version 1.3 of python-cpopen that raises a proper exception
when an executable is missing.

Change-Id: I068acf5ca0ad0813aaef660770de79958bd0b763
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22997
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/API.py
1 file changed, 22 insertions(+), 36 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22997
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I068acf5ca0ad0813aaef660770de79958bd0b763
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list