Change in vdsm[master]: guestIF: Adding guest agent API versioning support
danken at redhat.com
danken at redhat.com
Wed Feb 5 14:14:15 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: guestIF: Adding guest agent API versioning support
......................................................................
Patch Set 14: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/17004/14/vdsm/guestIF.py
File vdsm/guestIF.py:
Line 237: self.guestInfo['memoryStats'][k] = str(v)
Line 238:
Line 239: if 'apiVersion' in args:
Line 240: # The guest agent supports API Versioning
Line 241: self._handleApiVersion(args['apiVersion'])
Python is case-sensitive, and we need unit tests to catch such errors!
Line 242: elif self.effectiveApiVersion != _API_DISABLED_VALUE:
Line 243: # Older versions of the guest agent (before the introduction
Line 244: # API versioning) do not report this field
Line 245: # Disable the API if not already disabled (e.g. after
--
To view, visit http://gerrit.ovirt.org/17004
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9095b528c2c910f12d5f170088a458bf11c71910
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list