Change in vdsm[master]: sp: stop all poolMonitoredDomains on disconnect

abaron at redhat.com abaron at redhat.com
Wed Feb 5 14:00:23 UTC 2014


Ayal Baron has posted comments on this change.

Change subject: sp: stop all poolMonitoredDomains on disconnect
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/24088/1/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 628:         return True
Line 629: 
Line 630:     @unsecured
Line 631:     def stopMonitoringDomains(self):
Line 632:         for sdUUID in self.domainMonitor.poolMonitoredDomains:
we need to check whether we're actually managing the same data in 2 places (getDomains, poolMonitoredDomains) if so we need to unify the 2 (possibly simply by implementing getDomains using poolMonitoredDomains
Line 633:             self.domainMonitor.stopMonitoring(sdUUID)
Line 634:         return True
Line 635: 
Line 636:     @unsecured


-- 
To view, visit http://gerrit.ovirt.org/24088
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc77988b01491f687fd7afa6bb34512b5f2451af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list