Change in vdsm[master]: guestIF: Adding guest agent API versioning support

vfeenstr at redhat.com vfeenstr at redhat.com
Wed Feb 5 12:18:04 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: guestIF: Adding guest agent API versioning support
......................................................................


Patch Set 12:

(2 comments)

http://gerrit.ovirt.org/#/c/17004/12/vdsm/guestIF.py
File vdsm/guestIF.py:

Line 146:             apiVersion = int(version)
Line 147:         except ValueError:
Line 148:             self.log.warning("Received invalid version value: %s", version)
Line 149:             apiVersion = _MIN_SUPPORTED_API_VERSION
Line 150:         apiVersion = max(apiVersion, _MIN_SUPPORTED_API_VERSION)
> I do not understand. If a buggy agent sends a "gfagfdsag" version, why do w
Done
Line 151:         apiVersion = min(apiVersion, _MAX_SUPPORTED_API_VERSION)
Line 152:         return apiVersion
Line 153: 
Line 154:     def _setAPIVersion(self, version):


Line 191:                 self._clearReadBuffer()
Line 192:                 # Report the _MAX_SUPPORTED_API_VERSION on refresh to enable
Line 193:                 # the other side to see that we support API versioning
Line 194:                 self._forward('refresh',
Line 195:                               {'apiVersion': _MAX_SUPPORTED_API_VERSION})
> If we plan to have deprecation built into the protocol, we should expose _M
The _MIN_SUPPORTED_API_VERSION should stay always like this, because of backwards compatibility we cannot remove the support for the older messages. However with a negotiated higher supported version we can make it report other things instead of older messages, real deprecation unfortunately is not an option.
Line 196:                 self._stopped = False
Line 197:                 ret = True
Line 198:             else:
Line 199:                 self.log.debug("Failed to connect to %s with %d",


-- 
To view, visit http://gerrit.ovirt.org/17004
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9095b528c2c910f12d5f170088a458bf11c71910
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list