Change in vdsm[master]: API: return additional Hosted Engine information from vdsStats
gpadgett at redhat.com
gpadgett at redhat.com
Wed Feb 5 00:13:29 UTC 2014
Greg Padgett has posted comments on this change.
Change subject: API: return additional Hosted Engine information from vdsStats
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/23263/3/vdsm/API.py
File vdsm/API.py:
Line 1577: if host_id in stats:
Line 1578: i['active'] = stats[host_id]['live-data']
Line 1579: i['score'] = stats[host_id]['score']
Line 1580: i['localMaintenance'] = stats[host_id]['maintenance']
Line 1581: except Exception:
> catch only specific exceptions and don't swallow it with log
Same 'try-except-log' logic as before, around line 1240 in the old version. Reason is, I want to catch any errors from the ha library and log them rather than make the vdsStats request fail.
Line 1582: self.log.exception("failed to retrieve Hosted Engine HA info")
Line 1583: else:
Line 1584: self.log.debug("Hosted Engine HA is not installed")
Line 1585: return i
Line 1580: i['localMaintenance'] = stats[host_id]['maintenance']
Line 1581: except Exception:
Line 1582: self.log.exception("failed to retrieve Hosted Engine HA info")
Line 1583: else:
Line 1584: self.log.debug("Hosted Engine HA is not installed")
> you'll print that each getStat if haClient is not available. why do you nee
Removed (would move to a higher log level if possible, but it's really not necessary to see every time).
Line 1585: return i
Line 1586:
Line 1587: @staticmethod
Line 1588: def translateNetOptionsToNew(options):
--
To view, visit http://gerrit.ovirt.org/23263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaee2756d0652dc56439b8004e9260fcea927b708
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list