Change in vdsm[master]: clientIF: Teardown volume path only for VDSM images

nsoffer at redhat.com nsoffer at redhat.com
Tue Feb 4 13:08:43 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: clientIF: Teardown volume path only for VDSM images
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

Looks good except the unneeded parenthesis.

http://gerrit.ovirt.org/#/c/21973/6/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 325:         try:
Line 326:             if vm.isVdsmImage(drive):
Line 327:                 res = self.irs.teardownImage(drive['domainID'],
Line 328:                                              drive['poolID'], drive['imageID'])
Line 329:         except (TypeError):
Please remove the parenthesis, it has no meaning; (TypeError) is *not* a single item tuple (Python syntax edge case).
Line 330:             # paths (strings) are not deactivated
Line 331:             if not isinstance(drive, basestring):
Line 332:                 self.log.warning("Drive is not a vdsm image: %s",
Line 333:                                  drive, exc_info=True)


-- 
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list