Change in vdsm[master]: Adding with_jsonrpc global to spec set default to 1

dougsland at redhat.com dougsland at redhat.com
Tue Feb 4 12:12:33 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: Adding with_jsonrpc global to spec set default to 1
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/24033/2/vdsm.spec.in
File vdsm.spec.in:

Line 40: %if 0%{?fedora} >= 18
Line 41: %global with_systemd_macros 1
Line 42: %global with_tmpfiles_macro 1
Line 43: %endif
Line 44: 
I would add:
# Temporary global jsonrpc for WIP sub-package

or something like that, otherwise it can be forgetful
Line 45: %global with_jsonrpc 1
Line 46: 
Line 47: Name:           %{vdsm_name}
Line 48: Version:        @PACKAGE_VERSION@


-- 
To view, visit http://gerrit.ovirt.org/24033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7229fde2263d1add4c0e74aeb7d5d4e0694f3cda
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list