Change in vdsm[master]: spec: do not remove vdsm logs when pkg removed

danken at redhat.com danken at redhat.com
Sun Feb 2 21:02:16 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: spec: do not remove vdsm logs when pkg removed
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/23876/1/vdsm.spec.in
File vdsm.spec.in:

Line 693: 
Line 694: # After vdsm install we should create the logs files.
Line 695: # In the install session we create it but since we use
Line 696: # the ghost macro (in files session) the files are not included
Line 697: touch @VDSMLOGDIR@/{metadata.log,mom.log,supervdsm.log,vdsm.log}
Douglas actually added a comment explaining why it is not enough.
Line 698: chmod 0644 @VDSMLOGDIR@/{metadata.log,mom.log,supervdsm.log,vdsm.log}
Line 699: chown @VDSMUSER@:@VDSMGROUP@ @VDSMLOGDIR@/{metadata.log,mom.log,vdsm.log}
Line 700: chown root:root @VDSMLOGDIR@/supervdsm.log
Line 701: 


-- 
To view, visit http://gerrit.ovirt.org/23876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc8e62d5a0a6166c9141fe9d6016a525a3331694
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list