Change in vdsm[master]: multipath configurator: reload only if service is active

danken at redhat.com danken at redhat.com
Tue Dec 30 13:01:36 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: multipath configurator: reload only if service is active
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/36387/1/lib/vdsm/tool/configurators/multipath.py
File lib/vdsm/tool/configurators/multipath.py:

Line 146
Line 147
Line 148
Line 149
Line 150
> I have problem parsing the above multi-senstence.
service.service_reload should have the same semantics for sysv and systemd alike. Once this is done (in a separate patch), we can review this fix.


-- 
To view, visit http://gerrit.ovirt.org/36387
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1e8eceaaa486f05b1ea4f1733df669b2a44682a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list