Change in vdsm[master]: ipwrapperTests: prevent infinite stuck

danken at redhat.com danken at redhat.com
Tue Dec 30 11:59:59 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: ipwrapperTests: prevent infinite stuck
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/35901/4/tests/ipwrapperTests.py
File tests/ipwrapperTests.py:

Line 182:         finally:
Line 183:             # Stop the monitor and check that eventually StopIteration is
Line 184:             # raised.  There might be other system link events so we loop to
Line 185:             # exhaust them.
Line 186:             mon.stop()
> if it is stopped in _timeout, the second stop will raise Exception
I can live with that.
Line 187:         with self.assertRaises(StopIteration):
Line 188:             while True:
Line 189:                 iterator.next()
Line 190: 


-- 
To view, visit http://gerrit.ovirt.org/35901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie71eb5b33cabf5402f00815aa603bbc384159d56
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list