Change in vdsm[master]: tests: Improve assertNetworkExists and assertNetworkDoesntExist
ibarkan at redhat.com
ibarkan at redhat.com
Tue Dec 30 10:58:37 UTC 2014
Ido Barkan has posted comments on this change.
Change subject: tests: Improve assertNetworkExists and assertNetworkDoesntExist
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/35872/7/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 243: config = self.vdsm_net.config
Line 244: self.assertIn(networkName, netinfo.networks)
Line 245: if bridged is not None:
Line 246: self.assertEqual(bridged, netinfo.networks[networkName]['bridged'])
Line 247: if bridged:
> in every assert[Device]Exist we check just configuration of the device itse
Sorry for the late delay, I missed your (good) question.
for bond bridge explicut methods the code checks "self.assertIn(X, netinfo.bondings) so we indeed already check for the real presence of these devices.
Line 248: self.assertIn(networkName, netinfo.bridges)
Line 249: else:
Line 250: self.assertNotIn(networkName, netinfo.bridges)
Line 251: if bridgeOpts is not None and netinfo.networks[networkName]['bridged']:
--
To view, visit http://gerrit.ovirt.org/35872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7fd3c41634958c8e463fdce8a6498aa1a5f0ab1
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list