Change in vdsm[master]: tool: change configurators from classes to modules.
danken at redhat.com
danken at redhat.com
Tue Dec 30 09:07:34 UTC 2014
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tool: change configurators from classes to modules.
......................................................................
tool: change configurators from classes to modules.
Currently we have:
|-- configurators package
| |-- certificates.py module
| | |-- ModuleConfigure class
| |-- libvirt.py module
| | |-- ModuleConfigure class
| |-- sanlock.py module
| | |-- ModuleConfigure class
I am suggesting to make this flatter:
|-- configurators package
| |-- certificates.py module
| |-- libvirt.py module
| |-- sanlock.py module
Defaults moved from the less visible __init__.py to
the configurators consumer. What was once named a ModuleConfigurer is now called
a configurator module.
Change-Id: Iff5d588cfbbcfe0d5f4a90d624d24f21ef4cc580
Signed-off-by: Mooli Tayer <mtayer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/34047
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/tool/configurator.py
M lib/vdsm/tool/configurators/__init__.py
M lib/vdsm/tool/configurators/certificates.py
M lib/vdsm/tool/configurators/libvirt.py
M lib/vdsm/tool/configurators/multipath.py
M lib/vdsm/tool/configurators/sanlock.py
M lib/vdsm/tool/configurators/sebool.py
M tests/toolTests.py
8 files changed, 834 insertions(+), 875 deletions(-)
Approvals:
Yaniv Bronhaim: Looks good to me, but someone else must approve
mooli tayer: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34047
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff5d588cfbbcfe0d5f4a90d624d24f21ef4cc580
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list