Change in vdsm[master]: signals: Handle signals to non-main threads

nsoffer at redhat.com nsoffer at redhat.com
Sun Dec 28 16:34:22 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: signals: Handle signals to non-main threads
......................................................................


Patch Set 22:

(1 comment)

http://gerrit.ovirt.org/#/c/29392/22/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 30: import resource
Line 31: import signal
Line 32: import logging
Line 33: import logging.config
Line 34: import vdsm.infra.sigutils as sigutils
> Same style as the other import from vdsm.infra
This is clear, but this style is not consistent with any other import in vdsm, and I wonder if we have good reason to use this unusual style.
Line 35: import vdsm.infra.zombiereaper as zombiereaper
Line 36: 
Line 37: import numaUtils
Line 38: 


-- 
To view, visit http://gerrit.ovirt.org/29392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list