Change in vdsm[master]: v2v: adding os support version for v2v
shavivi at redhat.com
shavivi at redhat.com
Thu Dec 25 14:07:36 UTC 2014
Shahar Havivi has posted comments on this change.
Change subject: v2v: adding os support version for v2v
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.ovirt.org/#/c/36388/3/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 3671: ##
Line 3672: # @Host.getExternalVMs:
Line 3673: #
Line 3674: # Get information about the not-KVM virtual machines.
Line 3675: # If the functionality is not supported - NotSupported
> Lets be more precise with the exception name: v2v.NotSupported
Done,
Arik did add checks for older engines
Line 3676: # exception thrown
Line 3677: #
Line 3678: # @uri: libvirt connection uri
Line 3679: #
Line 3672: # @Host.getExternalVMs:
Line 3673: #
Line 3674: # Get information about the not-KVM virtual machines.
Line 3675: # If the functionality is not supported - NotSupported
Line 3676: # exception thrown
> thrown -> raised (no throw in Python)
Done
Line 3677: #
Line 3678: # @uri: libvirt connection uri
Line 3679: #
Line 3680: # @username: libvirt connection user name
http://gerrit.ovirt.org/#/c/36388/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 29: ''' Unexpected error while parsing libvirt domain xml '''
Line 30:
Line 31:
Line 32: class NotSupported(Exception):
Line 33: ''' v2v is not supported current os version '''
> not supported current -> not supported in current
Done
Line 34:
Line 35:
Line 36: def supported():
Line 37: return not (caps.getos() in (caps.OSName.RHEVH, caps.OSName.RHEL)
Line 39:
Line 40:
Line 41: def get_external_vms(uri, username, password):
Line 42: if not supported():
Line 43: raise NotSupported('v2v is not supported current os version')
> not supported current -> not supported in current
Done
Line 44:
Line 45: conn = libvirtconnection.open_connection(uri=uri,
Line 46: username=username,
Line 47: passwd=password)
--
To view, visit http://gerrit.ovirt.org/36388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a343a9634a90502feff46caed2c05b6af93ad5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list