Change in vdsm[master]: tool: change configurators from classes to modules.

mtayer at redhat.com mtayer at redhat.com
Thu Dec 25 12:25:23 UTC 2014


mooli tayer has posted comments on this change.

Change subject: tool: change configurators from classes to modules.
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.ovirt.org/#/c/34047/8/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 95: 
Line 96: 
Line 97: def _isconfigured(module):
Line 98:     """Return state of configuration. See configurators/__init__.py
Line 99: 
> what the __init__ file tells?
# Declare state of configuration
 #
 # YES   = Module configured.
 #
 # NO    = Module not configured before.
 #
 # MAYBE = Module configured before,
 #         configuration validity could not be determined.
 #
 # See also --force at configurators.py.
 YES, NO, MAYBE = range(3)
Line 100:     Note: returning NOT_CONFIGURED will cause vdsm to abort during
Line 101:     initialization.
Line 102: 
Line 103:     Note: after configure isconfigured should return MAYBE or YES.


http://gerrit.ovirt.org/#/c/34047/8/lib/vdsm/tool/configurators/multipath.py
File lib/vdsm/tool/configurators/multipath.py:

Line 107: 
Line 108: # If multipathd is up, it will be reloaded after configuration,
Line 109: # or started before vdsm starts, so service should not be stopped
Line 110: # during configuration.
Line 111: services = []
> why not () ?
I don't know.
not related to this patch.
Line 112: 
Line 113: 
Line 114: def configure():
Line 115:     """


-- 
To view, visit http://gerrit.ovirt.org/34047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5d588cfbbcfe0d5f4a90d624d24f21ef4cc580
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list