Change in vdsm[master]: qemu-img: Allow creation of zero-sized volumes

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 24 14:29:30 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: qemu-img: Allow creation of zero-sized volumes
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36276/1/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 127:         cmd.extend(("-F", backingFormat))
Line 128: 
Line 129:     cmd.append(image)
Line 130: 
Line 131:     if size is not None:
> IIUC current tests check that the generated command is as expected, the pro
Then we need another test that test the command when size==0. This should be very easy to add.
Line 132:         cmd.append(str(size))
Line 133: 
Line 134:     rc, out, err = utils.execCmd(cmd, cwd=cwdPath, deathSignal=signal.SIGKILL)
Line 135: 


-- 
To view, visit http://gerrit.ovirt.org/36276
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf8d493bcf3334bd96d96f5aa02cc564b7b83c9f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list