Change in vdsm[master]: netinfo: Modernize functions recognizing the usage of DHCP f...

danken at redhat.com danken at redhat.com
Wed Dec 24 10:18:50 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Modernize functions recognizing the usage of DHCP from lease files
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/36038/8/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 540:         elif line == 'lease {\n':
Line 541:             family = 4
Line 542:             iface = None
Line 543: 
Line 544:     return dhcpv4
dhcpv4_ifaces is a clearer name
Line 545: 
Line 546: 
Line 547: def _get_dhclient_ifaces(lease_files_globs):
Line 548:     """Return a set of interfaces configured using dhclient.


-- 
To view, visit http://gerrit.ovirt.org/36038
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b95d0223b35c3bbbcd736c28ed1dd7c2f9bd2bb
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list