Change in vdsm[master]: schema: verification of API.py and schema during UT

danken at redhat.com danken at redhat.com
Tue Dec 23 12:09:57 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: schema: verification of API.py and schema during UT
......................................................................


Patch Set 11: Code-Review+2

(1 comment)

raising score

http://gerrit.ovirt.org/#/c/35557/11/tests/schemaValidationTest.py
File tests/schemaValidationTest.py:

Line 70: 
Line 71:                 # ignore private methods
Line 72:                 if method_name.startswith('_'):
Line 73:                     continue
Line 74: 
> Done
Done where?

Given Francesco's +1, I'm fine with postponing the split to a follow up patch. Please do not forget it.
Line 75:                 try:
Line 76:                     # get args from schema
Line 77:                     method_args = bridge._getArgList(spec_class, method_name)
Line 78:                 except KeyError:


-- 
To view, visit http://gerrit.ovirt.org/35557
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If81cff3c988e00c8c4eda1809f481e1ae19398dd
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list