Change in vdsm[master]: testSetupNetworksAddDelDhcp: Modernize and prepare for a cle...
osvoboda at redhat.com
osvoboda at redhat.com
Tue Dec 23 09:47:31 UTC 2014
Ondřej Svoboda has posted comments on this change.
Change subject: testSetupNetworksAddDelDhcp: Modernize and prepare for a clean extension
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/36185/4/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1701: veth.setIP(left, IP_ADDRESS, IP_CIDR)
Line 1702: veth.setLinkUp(left)
Line 1703: with dnsmasqDhcp(left):
Line 1704: dhcpv4 = 'dhcp'
Line 1705: network_name = NETWORK_NAME
> I see no reason to "prepare" for randomization of this name.
Okay! I'll split the randomization from the patch actually extending the test and the renaming from here.
Line 1706: network = {network_name: {'nic': right, 'bridged': bridged,
Line 1707: 'bootproto': dhcpv4,
Line 1708: 'blockingdhcp': True}}
Line 1709:
--
To view, visit http://gerrit.ovirt.org/36185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4df973624bf8e9ca35e27ce6e6c34724d1a5cdc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list