Change in vdsm[master]: qemu-img convert: check/use "-T src_cache" option when avail...

danken at redhat.com danken at redhat.com
Mon Dec 22 23:23:14 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: qemu-img convert: check/use "-T src_cache" option when available
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/36308/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 242: 
Line 243: 
Line 244: # Testing capabilities
Line 245: 
Line 246: @utils.memoized
> This will be hard to test because of memoizing.
I love  http://gerrit.ovirt.org/34709, but it can take a long while until it's accepted (it needs to be stripped of its nice tests and moved into infra). I'm not sure Amador should wait for this to happen.
Line 247: def _supports_src_cache(command, out=None):
Line 248:     """
Line 249:     qemu-img has a new "-T src_cache" option to avoid cache source
Line 250:     image. This will check if "-T" option is available.


-- 
To view, visit http://gerrit.ovirt.org/36308
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list