Change in vdsm[master]: testSetupNetworksAddDelDhcp: Check that a DHCPv4 address is ...

osvoboda at redhat.com osvoboda at redhat.com
Mon Dec 22 20:11:30 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: testSetupNetworksAddDelDhcp: Check that a DHCPv4 address is in range
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/36186/4//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-12-15 17:37:17 +0100
Line 4: Commit:     Ondřej Svoboda <osvoboda at redhat.com>
Line 5: CommitDate: 2014-12-22 21:06:28 +0100
Line 6: 
Line 7: testSetupNetworksAddDelDhcp: Check that a DHCPv4 address is in range
To be fair, the original intent was to prove DHCPv6 was working when we didn't have a DHCPv6 lease file "parser". It is only one more way to be sure. The patch is almost isolated so we can just leave it out.
Line 8: 
Line 9: (At least) one address is now required to be in a range we know and control.
Line 10: Also introduce range checking for IPv6.
Line 11: 


-- 
To view, visit http://gerrit.ovirt.org/36186
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7e11e84b8f81c39c799fadfca06b7bde0a409c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list