Change in vdsm[master]: storageServer: Keep the original traceback

nsoffer at redhat.com nsoffer at redhat.com
Mon Dec 22 13:07:50 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: storageServer: Keep the original traceback
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36331/1/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 207: 
Line 208:         try:
Line 209:             self._mount.mount(self.options, self._vfsType)
Line 210:         except MountError:
Line 211:             t, v, tb = sys.exc_info()
> We already print the exc_info in the log.
If we use raise, it would raise the last error, which would be the OSError.

The fact that mount() prints error to the log should not effect this code that try to raise the MountError. Basically we should eliminate such duplicate traceback, and handle such logging in the upper layers.
Line 212:             self.log.error("Mount failed: %s", e, exc_info=True)
Line 213:             try:
Line 214:                 os.rmdir(self._getLocalPath())
Line 215:             except OSError:


-- 
To view, visit http://gerrit.ovirt.org/36331
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I746cd71d065849dda7a2b53d7b74b53265a36b36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list