Change in vdsm[master]: tool: change configurators from classes to modules.

mtayer at redhat.com mtayer at redhat.com
Sun Dec 21 16:55:32 UTC 2014


mooli tayer has posted comments on this change.

Change subject: tool: change configurators from classes to modules.
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.ovirt.org/#/c/34047/6/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 65: 
Line 66:     Cleanup vdsm's configuration.
Line 67: """
Line 68: 
Line 69: 
> remove that comment.. i already explained why somewhere. hard to maintain, 
This is doc for module configurator - aimed at implementors. it's different from vdsm-tool documentation
Line 70: from collections import deque
Line 71: import argparse
Line 72: import sys
Line 73: import traceback


http://gerrit.ovirt.org/#/c/34047/6/lib/vdsm/tool/configurators/certificates.py
File lib/vdsm/tool/configurators/certificates.py:

Line 53: 
> Have you deleted validate on purpose?
nope, thanks.


http://gerrit.ovirt.org/#/c/34047/6/lib/vdsm/tool/configurators/libvirt.py
File lib/vdsm/tool/configurators/libvirt.py:

Line 167: 
Line 168:                     utils.unpersist(TARGET)
Line 169:                     shutil.copyfile(packaged, TARGET)
Line 170:                     utils.persist(TARGET)
Line 171: 
> Shouldn't these 3 lined be indented as well?
They should!
Line 172:                 if (oldmod is not None and
Line 173:                         oldmod != os.stat(TARGET).st_mode):
Line 174:                     os.chmod(TARGET, oldmod)
Line 175:                 reloadConfiguration()


-- 
To view, visit http://gerrit.ovirt.org/34047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5d588cfbbcfe0d5f4a90d624d24f21ef4cc580
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list