Change in vdsm[master]: teach delNetworks to remove a network entity under a bridge

ibarkan at redhat.com ibarkan at redhat.com
Sun Dec 21 13:17:21 UTC 2014


Ido Barkan has posted comments on this change.

Change subject: teach delNetworks to remove a network entity under a bridge
......................................................................


Patch Set 11: Verified-1

(2 comments)

http://gerrit.ovirt.org/#/c/35921/11/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1177:             self.assertEquals(status, SUCCESS, msg)
Line 1178:             # the kernel bridge driver automatically updates the bridge to
Line 1179:             # the new minimum MTU of all of its connected interfaces
Line 1180:             self.assertMtu(BIG, NETWORK_NAME, second)
Line 1181:             self.assertEquals(bridge_index, get_bridge_index())
> Please add this check (test?) on the commit you actually make use of keep_b
Done
Line 1182: 
Line 1183:     @cleanupNet
Line 1184:     @permutations([[True], [False]])
Line 1185:     @RequireDummyMod


Line 1177:             self.assertEquals(status, SUCCESS, msg)
Line 1178:             # the kernel bridge driver automatically updates the bridge to
Line 1179:             # the new minimum MTU of all of its connected interfaces
Line 1180:             self.assertMtu(BIG, NETWORK_NAME, second)
Line 1181:             self.assertEquals(bridge_index, get_bridge_index())
> what is the current status of this on phoracek's f21 host?
I think I figured it out (hint: see osvoboda's comment here). A longer explanation sent by email.
Line 1182: 
Line 1183:     @cleanupNet
Line 1184:     @permutations([[True], [False]])
Line 1185:     @RequireDummyMod


-- 
To view, visit http://gerrit.ovirt.org/35921
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6bb891f23ef4550f90c6c7b057aef6302cf435c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list