Change in vdsm[master]: v2v: add volume size to disk info

shavivi at redhat.com shavivi at redhat.com
Sun Dec 21 09:12:10 UTC 2014


Shahar Havivi has posted comments on this change.

Change subject: v2v: add volume size to disk info
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36263/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 110:         source = disk.find('./source/[@file]')
Line 111:         if source is not None:
Line 112:             d['alias'] = source.get('file')
Line 113:             vol = conn.storageVolLookupByPath(source.get('file'))
Line 114:             if vol is not None and vol.info() is not None:
> standard practice in libvirt python bindings is to raise libvirtError if th
Done
Line 115:                 d['truesize'] = str(vol.info()[1])
Line 116:         params['disks'].append(d)
Line 117: 
Line 118: 


-- 
To view, visit http://gerrit.ovirt.org/36263
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7e9ba73514292cc2bb4a025d286e2c732e88a75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list