Change in vdsm[master]: netlink: event monitor (simple version)
phoracek at redhat.com
phoracek at redhat.com
Thu Dec 18 15:21:46 UTC 2014
Petr Horáček has posted comments on this change.
Change subject: netlink: event monitor (simple version)
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/36197/8/lib/vdsm/netlink/__init__.py
File lib/vdsm/netlink/__init__.py:
Line 125: return _rtnl_scope2str(scope_num, scope, sizeof(scope))
Line 126:
Line 127:
Line 128: # libnl/include/linux/rtnetlink.h
Line 129: _KNOWN_GROUPS = {
Use constants instead?
Line 130: 'link': 1, # RTNLGRP_LINK
Line 131: 'notify': 2, # RTNPGRP_NOTIFY
Line 132: 'neigh': 3, # RTNLGRP_NEIGH
Line 133: 'tc': 4, # RTNLGRP_TC
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list