Change in vdsm[master]: tool: change configure verb logic.
mtayer at redhat.com
mtayer at redhat.com
Thu Dec 18 14:37:12 UTC 2014
mooli tayer has posted comments on this change.
Change subject: tool: change configure verb logic.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/34100/3/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 331: def _should_configure(c, args):
Line 332: ret = True
Line 333: configured = getattr(c, 'isconfigured', lambda: configurators.NO)()
Line 334: configure_allowed = (configured != configurators.YES and
Line 335: (configured == configurators.NO or args.force))
> more readable will be:
you remove configured and then used it.
I've rewrote and applied your suggestion too.
Line 336: if getattr(c, 'validate', lambda: True)():
Line 337: ret = configure_allowed
Line 338: elif not configure_allowed:
Line 339: raise configurators.InvalidConfig(
--
To view, visit http://gerrit.ovirt.org/34100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I166fbae855ebff93ef84270f11b74f32fcc115c2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list