Change in vdsm[master]: hostdev: implement numvfs changing

danken at redhat.com danken at redhat.com
Thu Dec 18 11:11:49 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: hostdev: implement numvfs changing
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Please update the schema

http://gerrit.ovirt.org/#/c/36216/1/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 203:     def changeNumvfs(self, device_name, numvfs):
Line 204:         with open('/sys/bus/pci/devices/{}/sriov_numvfs'.format(
Line 205:                 device_name), 'w', 0) as f:
Line 206:             f.write('0')
Line 207:             f.write(numvfs)
let's assume that the arg is an int, and use str() here.
Line 208: 
Line 209:     def _runAs(self, user, groups, func, args=(), kwargs={}):
Line 210:         def child(pipe):
Line 211:             res = ex = None


-- 
To view, visit http://gerrit.ovirt.org/36216
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I110972fa12ffb7f5996fe46135644b5c0a11743b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list