Change in vdsm[master]: Using with_rhev flag in spec to configure rhev changes if re...

danken at redhat.com danken at redhat.com
Wed Dec 17 15:00:47 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Using with_rhev flag in spec to configure rhev changes if required
......................................................................


Patch Set 10: Code-Review-1

(3 comments)

http://gerrit.ovirt.org/#/c/35722/10//COMMIT_MSG
Commit Message:

Line 27: * Disabling creation of gluster packages during vdsm make process
Line 28:   As described in bz1031707, vdsm 3.3.0 should not provide vdsm-gluster
Line 29:   rpm
Line 30: 
Line 31: * Require specific rpm versions for rhev build
out of date comment
Line 32: 
Line 33: Change-Id: I30b554e5614bdda2b02538538b5e6514ae94eaf5
Line 34: Signed-off-by: Dima Kuznetsov <dkuznets at redhat.com>
Line 35: Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>


http://gerrit.ovirt.org/#/c/35722/10/vdsm.spec.in
File vdsm.spec.in:

Line 41: %if ! 0%{?rhev_build}
Line 42: %global with_gluster 1
Line 43: %endif
Line 44: 
Line 45: %if ! 0%{?rhel} || ! 0%{?rhev_build}
rhev is built ONLY on rhel.

So if it's not rhel, it's certainly not a rhev build. This predicate is wrong.

with_vhostmd is here since vhostmd is missing from Centos 6/7 + EPEL.
For everywhere else, we want to set with_vhostmd=1

Recently, we've added

 http://jenkins.ovirt.org/job/vhostmd_create-rpms_el6/
 http://jenkins.ovirt.org/job/vhostmd_create-rpms_el7/

which let us ship vhostmd within oVirt repos.

So basically, we can take vhostmd if it's not el, or if it's built out of koji.

 %if ! 0%{?rhel} ! 0%{fedora_koji_build}
 %global with_vhostmd 1
Line 46: %global with_vhostmd 1
Line 47: %endif
Line 48: 
Line 49: 


Line 44: 
Line 45: %if ! 0%{?rhel} || ! 0%{?rhev_build}
Line 46: %global with_vhostmd 1
Line 47: %endif
Line 48: 
needless whitespace
Line 49: 
Line 50: %if 0%{?fedora} || 0%{?rhel} >= 7
Line 51: %global with_systemd 1
Line 52: %endif


-- 
To view, visit http://gerrit.ovirt.org/35722
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30b554e5614bdda2b02538538b5e6514ae94eaf5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list