Change in vdsm[master]: infra: Add filecontrol module

mtayer at redhat.com mtayer at redhat.com
Wed Dec 17 13:41:09 UTC 2014


mooli tayer has posted comments on this change.

Change subject: infra: Add filecontrol module
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/35918/4/lib/vdsm/infra/filecontrol/tests.py
File lib/vdsm/infra/filecontrol/tests.py:

Line 21: 
Line 22: @with_fd
Line 23: def test_non_blocking(fd):
Line 24:     nt.assert_equals(0, filecontrol.set_non_blocking(fd))
Line 25:     nt.assert_true(os.O_NONBLOCK & fcntl.fcntl(fd, fcntl.F_GETFL))
equals(a,b)?
Line 26: 
Line 27: 
Line 28: @with_fd
Line 29: def test_blocking(fd):


-- 
To view, visit http://gerrit.ovirt.org/35918
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f455711d81e84db600647a2d5d80a5e7cadd5e2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list