Change in vdsm[master]: External hypervisor VMs integration

danken at redhat.com danken at redhat.com
Wed Dec 17 10:33:42 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: External hypervisor VMs integration
......................................................................


Patch Set 36: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/33309/36/vdsm/v2v.py
File vdsm/v2v.py:

Line 112:             d['alias'] = source.get('file')
Line 113:         params['disks'].append(d)
Line 114: 
Line 115: 
Line 116: def _add_networks(root, params):
much nicer names, thanks.
Line 117:     params['networks'] = []
Line 118:     interfaces = root.findall('.//interface')
Line 119:     for iface in interfaces:
Line 120:         i = {}


-- 
To view, visit http://gerrit.ovirt.org/33309
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3
Gerrit-PatchSet: 36
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list