Change in vdsm[master]: schema: verify line length to be shorter than 80
ybronhei at redhat.com
ybronhei at redhat.com
Wed Dec 17 07:12:38 UTC 2014
Yaniv Bronhaim has posted comments on this change.
Change subject: schema: verify line length to be shorter than 80
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.ovirt.org/#/c/36126/2/tests/schemaValidationTest.py
File tests/schemaValidationTest.py:
Line 46: longer.append('line [%d] %s' % (i + 1, line))
Line 47:
Line 48: if len(longer) > 0:
Line 49: raise AssertionError('Lines longer than 80\n%s'
Line 50: % '\n'.join(longer))
> It is purely usability. When I run first check I had good number of lines l
how can line number be not enough in this case..? but i don't mind so much
Line 51:
Line 52: def _get_path(self):
Line 53: testPath = os.path.realpath(__file__)
Line 54: dirName = os.path.split(testPath)[0]
Line 52: def _get_path(self):
Line 53: testPath = os.path.realpath(__file__)
Line 54: dirName = os.path.split(testPath)[0]
Line 55: return os.path.join(
Line 56: dirName, '..', 'vdsm', 'rpc', 'vdsmapi-schema.json')
> I am not sure what do you suggest here. We need to find where the schema is
ok.
Line 57:
Line 58: def _validate(self, api_mod):
Line 59: bridge = Bridge.DynamicBridge()
Line 60:
--
To view, visit http://gerrit.ovirt.org/36126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2bdb45f80d9f57c5169b104a9b4e4ca1eef4258
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list