Change in vdsm[master]: fixing race while sampling interfaces

ibarkan at redhat.com ibarkan at redhat.com
Wed Dec 17 06:41:29 UTC 2014


Ido Barkan has posted comments on this change.

Change subject: fixing race while sampling interfaces
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.ovirt.org/#/c/36138/5/tests/samplingTests.py
File tests/samplingTests.py:

Line 34: from testlib import permutations, expandPermutations
Line 35: from testlib import VdsmTestCase as TestCaseBase
Line 36: from monkeypatch import MonkeyPatchScope
Line 37: 
Line 38: NEW_INTERFACE = 'newinterface'
> no need to expose these on the module level, I believe.
Done
Line 39: NEW_VLAN = 'newvlan'
Line 40: 
Line 41: 
Line 42: class SamplingTests(TestCaseBase):


Line 126: 
Line 127: @contextmanager
Line 128: def dummy(dummy_name):
Line 129:     try:
Line 130:         ipwrapper.linkAdd(dummy_name, 'dummy')
> the try-block should begin only after having created the dummy device. then
Done
Line 131:         yield
Line 132:     finally:
Line 133:         _try_remove_link(dummy_name)
Line 134: 


-- 
To view, visit http://gerrit.ovirt.org/36138
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I059a5bfa4c140d88f512dc9a51d18f02956710de
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list