Change in vdsm[master]: storageServer: Improve iscsi connection logging

Federico Simoncelli fsimonce at redhat.com
Tue Dec 16 22:50:14 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: storageServer: Improve iscsi connection logging
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

http://gerrit.ovirt.org/#/c/36028/3/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 375: 
Line 376:     def connect(self):
Line 377:         iscsi.addIscsiNode(self._iface, self._target, self._cred)
Line 378: 
Line 379:     def match(self, session):
Ah nice, so isSession was used only for this purpose? (Still prefer _matchSession, but it's just taste).
Line 380:         target = session.target
Line 381:         portal = target.portal
Line 382:         iface = session.iface
Line 383:         cred = session.credentials


Line 423:             else:
Line 424:                 self._lastSessionId = session.id
Line 425:                 return session
Line 426: 
Line 427:         self.log.debug("Session mismatch: %s", [str(e) for e in errors])
Minor (ignore if you're not pushing again for other reasons): "mismatches"
Line 428:         raise OSError(errno.ENOENT, "Session not found")
Line 429: 
Line 430:     def isConnected(self):
Line 431:         try:


-- 
To view, visit http://gerrit.ovirt.org/36028
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de4ec72f09777e84273933ff41e9d1424e7aa09
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list