Change in vdsm[master]: netlink: event monitor (simple version)
phoracek at redhat.com
phoracek at redhat.com
Tue Dec 16 14:43:05 UTC 2014
Petr Horáček has posted comments on this change.
Change subject: netlink: event monitor (simple version)
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36197/1/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:
Line 149: msg_type = _nl_object_get_msgtype(obj)
Line 150: if msg_type in _EVENTS.keys():
Line 151: obj_dict['event'] = _EVENTS[msg_type]
Line 152: else:
Line 153: # TODO: do we want this?
> not in my opinion. Let's explode with KeyError
i realized, i can't raise an Exception inside a C function. plus if i could, it would be raised inside another thread.
Line 154: obj_dict['event'] = msg_type
Line 155: queue.put(obj_dict)
Line 156:
Line 157:
--
To view, visit http://gerrit.ovirt.org/36197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f4fcfde87ad51eb832f54862371b4da1281826e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list