Change in vdsm[master]: sd: remove unused volumeExists method

ykaplan at redhat.com ykaplan at redhat.com
Tue Dec 16 12:43:59 UTC 2014


Yeela Kaplan has uploaded a new change for review.

Change subject: sd: remove unused volumeExists method
......................................................................

sd: remove unused volumeExists method

Change-Id: I3d95e281c1f9824ec690db40f1d5fb62404f11e0
Signed-off-by: Yeela Kaplan <ykaplan at redhat.com>
---
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
2 files changed, 0 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/36209/1

diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index 36078d0..caaef6b 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -602,16 +602,6 @@
         """
         return blockVolume.BlockVolume
 
-    def volumeExists(self, imgPath, volUUID):
-        """
-        Return True if the volume volUUID exists
-        """
-        try:
-            lvm.getLV(self.sdUUID, volUUID)
-        except se.LogicalVolumeDoesNotExistError:
-            return False
-        return True
-
     def getVSize(self, imgUUID, volUUID):
         """ Return the block volume size in bytes. """
         try:
diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index 8c2c550..127ec9a 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -302,13 +302,6 @@
         """
         return fileVolume.FileVolume
 
-    def volumeExists(self, imgPath, volUUID):
-        """
-        Return True if the volume volUUID exists
-        """
-        volPath = os.path.join(imgPath, volUUID)
-        return self.oop.fileUtils.pathExists(volPath)
-
     def getVSize(self, imgUUID, volUUID):
         """ Returns file volume size in bytes. """
         volPath = os.path.join(self.mountpoint, self.sdUUID, 'images',


-- 
To view, visit http://gerrit.ovirt.org/36209
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d95e281c1f9824ec690db40f1d5fb62404f11e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list