Change in vdsm[master]: utils: Make CommandPath try to find the executable

danken at redhat.com danken at redhat.com
Tue Dec 16 12:29:48 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: utils: Make CommandPath try to find the executable
......................................................................


utils: Make CommandPath try to find the executable

Before this patch, if the executable was not one of the proposed
paths in the parameters, it would raise straight an ENOENT OSError.
With this patch, it will use distutils find_executable before
bailing out.

Change-Id: I0bfa722778e295e23f03791179bf8c53172d34b2
Signed-off-by: Antoni Segura Puimedon <toni at midokura.com>
Reviewed-on: http://gerrit.ovirt.org/36166
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/utils.py
M tests/utilsTests.py
2 files changed, 17 insertions(+), 3 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/36166
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0bfa722778e295e23f03791179bf8c53172d34b2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ryu Ishimoto <ryu at midokura.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list