Change in vdsm[master]: vm: abort vm start if can't read pid
fromani at redhat.com
fromani at redhat.com
Mon Dec 15 10:49:20 UTC 2014
Francesco Romani has posted comments on this change.
Change subject: vm: abort vm start if can't read pid
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36129/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2704: self.conf['pauseCode'] = self._initTimePauseCode
Line 2705: if self._initTimePauseCode == 'ENOSPC':
Line 2706: self.cont()
Line 2707:
Line 2708: self.conf['pid'] = str(self._getPid())
> Yep, it is called in recovery. We are in Vm._domDependentInit(), which is c
turns out that the separate patch will be just an if:, so I'll squash it on that one.
Line 2709:
Line 2710: nice = int(self.conf.get('nice', '0'))
Line 2711: nice = max(min(nice, 19), 0)
Line 2712:
--
To view, visit http://gerrit.ovirt.org/36129
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b80baba14caded2fb3ef74451498751347323ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list