Change in vdsm[master]: fixing race while sampling interfaces
danken at redhat.com
danken at redhat.com
Sun Dec 14 18:54:21 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: fixing race while sampling interfaces
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Didn't you say you'd like to add a unit test for this case?
http://gerrit.ovirt.org/#/c/36138/2/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 215: raise ValueError('Boot time not present')
Line 216:
Line 217:
Line 218: def _get_interfaces_and_samples():
Line 219: links_and_samples = dict()
{} is (was??) considerably faster than dict().
And you have a double indent, too.
Line 220: for link in getLinks():
Line 221: try:
Line 222: links_and_samples[link.name] = InterfaceSample(link)
Line 223: except IOError as e:
--
To view, visit http://gerrit.ovirt.org/36138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I059a5bfa4c140d88f512dc9a51d18f02956710de
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list