Change in vdsm[master]: schema: verify line length to be shorter than 80

fromani at redhat.com fromani at redhat.com
Fri Dec 12 16:35:08 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: schema: verify line length to be shorter than 80
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Although I like the idea and I'm happy to see this change, I believe we should move it in a different testsuite. -1 only for that reason, I'm fine otherwise.
(and I must admit I haven't checked each change to schema)

http://gerrit.ovirt.org/#/c/36126/1/tests/vmApiTests.py
File tests/vmApiTests.py:

Line 83:             with ensureVmStats(testvm):
Line 84:                 self.assertVmStatsSchemaCompliancy('RunningVmStats',
Line 85:                                                    testvm.getStats())
Line 86: 
Line 87:     def testLineLength(self):
I like that but this doesn't really fit here.

The purpose of these tests is to check that the return values of the Vm API have all the fields mandated by the spec (They are indeed still primitive and I should improve them, probably building on the blocks you provided recently).

I believe the most fit place is your own schemaValidationTests.py.
Line 88:         with open(self.getPath()) as f:
Line 89:             longer = []
Line 90:             for i, line in enumerate(f):
Line 91:                 if len(line) > 80:


-- 
To view, visit http://gerrit.ovirt.org/36126
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2bdb45f80d9f57c5169b104a9b4e4ca1eef4258
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list