Change in vdsm[master]: netlink: ignore_enodev parameter in *_info

danken at redhat.com danken at redhat.com
Fri Dec 12 11:44:24 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netlink: ignore_enodev parameter in *_info
......................................................................


Patch Set 17: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/34925/17/lib/vdsm/netlink/addr.py
File lib/vdsm/netlink/addr.py:

Line 38:                     yield _addr_info(addr, link_cache=link_cache)
Line 39:                     addr = _nl_cache_get_next(addr)
Line 40: 
Line 41: 
Line 42: def _addr_info(addr, link_cache=None, ignore_enodev=False):
we don't really need the new argument: it takes effect only when link_cache=None, and it may well be the only behaviour of this function.

Let us return "label" only when it is available. In case of the current usafe by iter_addr, it would always be reported as we use a cache there.
Line 43:     """Returns a dictionary with the address information."""
Line 44:     index = _rtnl_addr_get_ifindex(addr)
Line 45:     data = {'index': index,
Line 46:             'family': _af_to_str(_rtnl_addr_get_family(addr)),


-- 
To view, visit http://gerrit.ovirt.org/34925
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41dfc7178144ae35a6b5bb52c185a337c94138ba
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list