Change in vdsm[master]: storageServer: Improve iscsi connection logging

Federico Simoncelli fsimonce at redhat.com
Fri Dec 12 11:29:58 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: storageServer: Improve iscsi connection logging
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36028/1/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 414:         return True
Line 415: 
Line 416:     def getSessionInfo(self):
Line 417:         for session in iscsi.iterateIscsiSessions():
Line 418:             if self.isSession(session):
> It is debug level - how do you suggest to debug issues where existing iscsi
If you have 10 session at each getSessionInfo in the worst case you may get up to 9 debug "mismatch" entries and no successful messages, how's that simplifying debugging?

Just log before line 422 (before raise) when you already know that you haven't matched any entry.
Line 419:                 self._lastSessionId = session.id
Line 420:                 return session
Line 421: 
Line 422:         raise OSError(errno.ENOENT, "Session not found")


-- 
To view, visit http://gerrit.ovirt.org/36028
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de4ec72f09777e84273933ff41e9d1424e7aa09
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list