Change in vdsm[master]: hostdev: report totalvfs

danken at redhat.com danken at redhat.com
Thu Dec 11 11:11:22 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: hostdev: report totalvfs
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

http://gerrit.ovirt.org/#/c/35891/5/vdsm/hostdev.py
File vdsm/hostdev.py:

Line 32: 
Line 33: def _sriov_totalvfs(device_name):
Line 34:     with open('/sys/bus/pci/devices/{}/sriov_totalvfs'.format(
Line 35:             _name_to_pci_path(device_name))) as f:
Line 36:         return str(int(f.read()))
we can (and should) report totalvfs as a true unsigned int.
Line 37: 
Line 38: 
Line 39: def _parse_device_params(device_xml):
Line 40:     """


http://gerrit.ovirt.org/#/c/35891/5/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 3757: # @vendor_id:       Hexadecimal representation of the vendor
Line 3758: #
Line 3759: # @vendor:          String representation of the vendor
Line 3760: #
Line 3761: # @totalvfs:        #optional Number of available virtual functions 
trailing whitespace
Line 3762: #                   (if sriov capable)
Line 3763: #
Line 3764: # Since: 4.17.0
Line 3765: ##


Line 3765: ##
Line 3766: {'type': 'HostDeviceParams',
Line 3767:  'data': {'capability': 'str', 'iommu_group': 'uint',
Line 3768:           'parent': 'str', 'product_id': 'str', 'product': 'str',
Line 3769:           'vendor_id': 'str', 'vendor': 'str', 'totalvfs': 'int'}}
int->uint
Line 3770: 
Line 3771: ##
Line 3772: # @HostDevice:
Line 3773: #


-- 
To view, visit http://gerrit.ovirt.org/35891
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic54228deb64db200615ef8e2ba8f51e449e68022
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list