Change in vdsm[master]: hostdev: report totalvfs

mpolednik at redhat.com mpolednik at redhat.com
Thu Dec 11 09:10:18 UTC 2014


Martin Polednik has posted comments on this change.

Change subject: hostdev: report totalvfs
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/35891/4/vdsm/hostdev.py
File vdsm/hostdev.py:

Line 32: 
Line 33: def _sriov_totalvfs(device_name):
Line 34:     with open('/sys/bus/pci/devices/{}/sriov_totalvfs'.format(
Line 35:             _name_to_pci_path(device_name))) as f:
Line 36:         return str(int(f.read()))
> actually might not be needed anymore since it is reported as str anyway, I'
edit: strips newline
Line 37: 
Line 38: 
Line 39: def _parse_device_params(device_xml):
Line 40:     """


-- 
To view, visit http://gerrit.ovirt.org/35891
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic54228deb64db200615ef8e2ba8f51e449e68022
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list