Change in vdsm[master]: adding tx/rx statistic to getInterfacesStat
danken at redhat.com
danken at redhat.com
Thu Dec 11 07:57:55 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: adding tx/rx statistic to getInterfacesStat
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35061/5/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 294: if nics is None:
Line 295: self.assertNotIn(bondName, netinfo.bondings,
Line 296: '%s found unexpectedly' % bondName)
Line 297: else:
Line 298: self.assertTrue(bondName not in netinfo.bondings or (set(nics) !=
this whitespace change is unrelated to this change, and it breaks pep8.
Line 299: set(netinfo.bondings[bondName]['slaves'])),
Line 300: '%s found unexpectedly' % bondName)
Line 301: if config is not None:
Line 302: self.assertTrue(bondName not in config.bonds or (set(nics) !=
--
To view, visit http://gerrit.ovirt.org/35061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I314a04570dec56677168e0fdb4a7824d299dbd65
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amir Shladovsky <a.shlado at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list