Change in vdsm[master]: There is no need to decorate all tests with RequireDummyMod

danken at redhat.com danken at redhat.com
Wed Dec 10 11:44:02 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: There is no need to decorate all tests with RequireDummyMod
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I'm marking with -1 only because this needs to be rebase without the removal of ValidateRunningAsRoot

http://gerrit.ovirt.org/#/c/36050/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-12-10 11:30:17 +0200
Line 6: 
Line 7: There is no need to decorate all tests with RequireDummyMod
Line 8: 
Line 9: This is since setupModule already dummy module to be loaded in
Please mention that this is the case since commit 87aed3428603 - we should have moved the decorator back then.
Line 10: order to add dummy links. So even tests that are not decorated with
Line 11: RequireDummyMod actually require it.
Line 12: 
Line 13: Change-Id: I03c9b2028ba684a274184fbaaa6a7bbf78992d01


-- 
To view, visit http://gerrit.ovirt.org/36050
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I03c9b2028ba684a274184fbaaa6a7bbf78992d01
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list