Change in vdsm[master]: testSetupNetworksAddDelDhcp: Check for DHCPv4 also on the de...

osvoboda at redhat.com osvoboda at redhat.com
Wed Dec 10 01:30:11 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: testSetupNetworksAddDelDhcp: Check for DHCPv4 also on the device (or bridge)
......................................................................


Patch Set 1: Verified+1

(1 comment)

The test still works on F20, and it _should_ continue working on other platforms.

(And please ignore the previous suggestion.)

http://gerrit.ovirt.org/#/c/35982/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1740:         with vethIf() as (left, right):
Line 1741:             veth.setIP(left, IP_ADDRESS, IP_CIDR)
Line 1742:             veth.setLinkUp(left)
Line 1743:             with dnsmasqDhcp(left):
Line 1744:                 dhcpv4 = 'dhcp'
> Rename to dhcp4 for consistency with the rest of code?
Nope, promote dhcpv4 instead.
Line 1745:                 network = {NETWORK_NAME: {'nic': right, 'bridged': bridged,
Line 1746:                                           'bootproto': dhcpv4,
Line 1747:                                           'blockingdhcp': True}}
Line 1748: 


-- 
To view, visit http://gerrit.ovirt.org/35982
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4c2651d12727727ead8a283b67de23340d98426
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list