Change in vdsm[master]: jsonrpc: VM_updateVmPolicy

fromani at redhat.com fromani at redhat.com
Tue Dec 9 15:10:16 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: jsonrpc: VM_updateVmPolicy
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

-1 because a question

http://gerrit.ovirt.org/#/c/35556/3/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:

Line 465:     'VM_setCpuTuneQuota': {'ret': 'taskStatus'},
Line 466:     'VM_setNumberOfCpus': {'ret': 'vmList'},
Line 467:     'VM_setIoTune': {'ret': 'taskStatus'},
Line 468:     'VM_updateDevice': {'ret': 'vmList'},
Line 469:     'VM_updateVmPolicy': {'ret': 'taskStatus'},
Doesn't seem a taskStatus the same way as it is in
Task_getStatus.

It seems just a regular API return code.
Line 470:     'Volume_copy': {'ret': 'uuid'},
Line 471:     'Volume_create': {'ret': 'uuid'},
Line 472:     'Volume_delete': {'ret': 'uuid'},
Line 473:     'Volume_getInfo': {'ret': 'info'},


-- 
To view, visit http://gerrit.ovirt.org/35556
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3e0a675b0574c25a2602f672ed6a36a05547c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list