Change in vdsm[master]: teach delNetworks to remove a network entity under a bridge

danken at redhat.com danken at redhat.com
Tue Dec 9 14:09:01 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: teach delNetworks to remove a network entity under a bridge
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/35921/5/vdsm/network/api.py
File vdsm/network/api.py:

Line 456:         if bonding is not None:
Line 457:             # this is a hack.
Line 458:             # we disconnect the bond from the bridge so the configurator will
Line 459:             # allow the bond to be removed
Line 460:             _delete_bridge_interface(network, bonding)
I believe we need to disconeect any underlying device (be it bonding, vlan or nic).

consider testing this scenario with no bond.
Line 461: 
Line 462:         net_ent_to_remove = net_ent.port
Line 463:     else:
Line 464:         net_ent_to_remove = net_ent


Line 757:             if network in _netinfo.networks:
Line 758:                 logger.debug("Removing network %r", network)
Line 759:                 delNetwork(network, configurator=configurator, force=force,
Line 760:                            implicitBonding=False, _netinfo=_netinfo,
Line 761:                            force_bridge_removal=('remove' in attrs))
no need for this yet.
Line 762:                 _netinfo.updateDevices()
Line 763:                 del _netinfo.networks[network]
Line 764:             elif network in libvirt_nets:
Line 765:                 # If the network was not in _netinfo but is in the networks


-- 
To view, visit http://gerrit.ovirt.org/35921
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6bb891f23ef4550f90c6c7b057aef6302cf435c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list